fix: don't die if we can't encode file metadata on upload#62208
Merged
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
come-nc and
salmart-dev
and removed request for
a team
July 15, 2026 22:29
Member
Author
|
Fixes #62095 |
CarlSchwan
approved these changes
Jul 16, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
filemetadata-serialize-fail
branch
from
July 16, 2026 05:57
c0d065f to
0d74414
Compare
Member
|
/backport! to stable34 |
Member
|
/backport! to stable33 |
susnux
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the
json_encodefails, don't die with an error, instead log the failure and continue without saving the metadata.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)